Repository navigation
test: replace HMR navigation helper with fixture readiness - #23853
leracherry wants to merge 1 commit into
Conversation
leracherry
changed the title
bd4511e to
6b8c968
Compare
|
Hmmm, this may not be the correct way to fix it. We should probably remove |
|
Thanks for reviewing. I tested replacing all three Would you prefer replacing the helper with browser-observable readiness/reload checks, or addressing the navigation/registration behavior in production first? I restored the experiment so the current patch is unchanged while I clarify the direction. |
|
Reworked this to remove All three HMR specs pass in bundled and normal dev. The delayed-registration regression fails with the readiness wait removed. The description has the current validation results. Could you review this revised approach? |
leracherry
changed the title
09c5427 to
edc5b11
Compare
|
Following up on the revised approach: gotoLatestBuild has been removed and replaced with fixture-owned readiness checks, as described above. The latest CI run passes and the branch is conflict-free. Could you take another look when convenient? |
After an HMR update, navigation can briefly load the bundled-dev fallback page. A test that edits a file before the final page reconnects can lose the update.
Remove
gotoLatestBuildand wait for a DOM marker set by the fixture after an HMR round trip. This lets the test wait for the page it will actually edit. The file-restoration test also waits for the parent update before the next navigation.Refs #23028.
Rebased onto
db8b119. The build and all three HMR specs passed locally: 44 tests in bundled dev and 63 in normal dev. The delayed-registration regression timed out without the readiness wait in the earlier validation. The previous CI run passed on Linux, macOS, and Windows.